Add return_connection_header=False arg #1445
Conversation
... to seek_and_read_message_data_record, for BagReady102.
Otherwise we get this error (e.g. using rqt_bag):
File ".../lib/python2.7/dist-packages/rosbag/bag.py", line 1299, in _read_message
return self._reader.seek_and_read_message_data_record(position, raw)
TypeError: seek_and_read_message_data_record() takes exactly 4 arguments (3 given)
|
I see the problem— thanks for tracking this down. Yeah, it definitely should have been a default value param. LGTM. |
|
The debian stretch test failed on the I wonder if this could be merged despite of that failure. @dirk-thomas BTW I don't really understand why the |
|
I didn't see #1444 when I created this, which provides a slightly different fix. @mikepurvis @dirk-thomas I guess you can choose one to merge and close the other. |
|
@efernandez ros-visualization/rqt_bag#27, just in case you didn't see the issue |
|
Thanks @VictorLamoine , this addresses ros-visualization/rqt_bag#27 Just waiting for review. |
|
@dirk-thomas Sorry to ping but this issue is quite annoying, it forces to compile Either this merge request or #1444 does the job. |
|
👍 |
|
Closing in favor of #1473. |
|
Thank you for contributing the patch - the commit is part of the combined PR. |
Add
return_connection_header=Falsearg toseek_and_read_message_data_record, forBagReady102.Otherwise we get this error (e.g. using
rqt_bag):This bug was introduced by @ddimarco in 752cf1f, that addressed #1372
rqt_bagis impacted by this. I can't see the contents of any message.@mikepurvis for review, since he merged it and should know better the context of the original change.